Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| cp -r "LICENSE" "$ROOT/lib/bundles/vue" | ||
| cp -r "package.json" "$ROOT/lib/bundles/vue" | ||
| cp -r "README.md" "$ROOT/lib/bundles/vue" | ||
| cp -r "syntaxes" "$ROOT/lib/bundles/vue" |
There was a problem hiding this comment.
Script omits copying languages/ directory for Vue bundle
High Severity
The Vue bundle's package.json references language configuration files at ./languages/vue-language-configuration.json, ./languages/markdown-language-configuration.json, and ./languages/sfc-template-language-configuration.json, but the copy commands only copy LICENSE, package.json, README.md, and syntaxes. The languages/ directory from the upstream repo is never copied. VSCBundleReader.readPreferences() silently returns empty results when these files are missing, so the Vue bundle will lack bracket matching, auto-closing pairs, comment toggling, and indentation rules.
Reviewed by Cursor Bugbot for commit fbb1e3b. Configure here.
There was a problem hiding this comment.
it seems to work fine without it, but i've added them just in case
There was a problem hiding this comment.
adding these files causes it to crash since these files are missing a mandatory field - #3480 (comment)
i've dropped that commit because it seems to work fine without them anyway
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4c5de86. Configure here.
plugins/textmate/lib/bundles/vue/languages/markdown-language-configuration.json
Outdated
Show resolved
Hide resolved
|
Hi, please check our Contributing guidelines and adjust the PR accordingly. |
DetachHead
force-pushed
the
vue-upstream
branch
from
fbb1e3b to
d21d9cf
Compare
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
i've created a youtrack issue and updated the commit message to reference it |
3 participants
Note
Medium Risk
Adds a large vendored Vue TextMate grammar/language configuration bundle and updates the bundle-fetch script to clone from an additional upstream repo, which can affect syntax highlighting behavior and introduces dependency on an external source during bundle updates.
Overview
Adds a new
plugins/textmate/lib/bundles/vuebundle (fromvuejs/language-tools/Volar) including Vue SFC TextMate grammar, Vue/Markdown/HTML language configurations, and injection grammars for directives, interpolations, and Vue code blocks in Markdown/MDX.Updates
plugins/textmate/loadVSCBundles.shto clonevuejs/language-toolsand copy the Vue bundle’sLICENSE,package.json,README.md,syntaxes, andlanguagesinto the repo during bundle refresh.Reviewed by Cursor Bugbot for commit 4c5de86. Bugbot is set up for automated code reviews on this repo. Configure here.